Conversation
- Fix Python syntax check to use exit status code in addition to output when determining if py_compile failed. Some environments don't produce output on syntax errors but do return non-zero exit status. - Add Content-Type: text/plain header to Python script_syntax_check and script_instrumented API requests. Without this header, Rails was not reading the request body correctly, causing empty text to be passed. - Show only the error message for CheckError exceptions instead of full stack trace, matching Ruby behavior. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2737 +/- ##
==========================================
- Coverage 79.22% 79.22% -0.01%
==========================================
Files 670 670
Lines 54178 54182 +4
Branches 734 734
==========================================
+ Hits 42924 42927 +3
- Misses 11174 11175 +1
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcosgriff
approved these changes
Jan 16, 2026
jmthomas
added a commit
that referenced
this pull request
Mar 21, 2026
Fix Python script syntax check and CheckError display
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Python syntax check to use exit status code in addition to output when determining if py_compile failed. Some environments don't produce output on syntax errors but do return non-zero exit status.
Add Content-Type: text/plain header to Python script_syntax_check and script_instrumented API requests. Without this header, Rails was not reading the request body correctly, causing empty text to be passed.
Show only the error message for CheckError exceptions instead of full stack trace, matching Ruby behavior.