Clear transient screen errors and fix screen overlay in Command Sender#2733
Merged
Clear transient screen errors and fix screen overlay in Command Sender#2733
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2733 +/- ##
==========================================
- Coverage 79.22% 78.31% -0.92%
==========================================
Files 670 473 -197
Lines 54178 34451 -19727
Branches 734 734
==========================================
- Hits 42924 26979 -15945
+ Misses 11174 7392 -3782
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clayandgen
approved these changes
Jan 15, 2026
jmthomas
added a commit
that referenced
this pull request
Mar 21, 2026
Clear transient screen errors and fix screen overlay in Command Sender
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this fix if a screen in Command Sender has an error the entire Command Sender screen darkens.
INST SETPARAMSand edit the screen to add a bad item. Verify before and after behavior.This also fixes the transient screen error issue.
zdocker pause cosmos-openc3-cosmos-cmd-tlm-api-1. Observe screen error (dimming). Thendocker unpause cosmos-openc3-cosmos-cmd-tlm-api-1and observe recovery.closes #2720