Conversation
…F-8 text Binary data like 0xDEAD that happens to be valid UTF-8 (decodes to U+07AD Thaana script) was incorrectly being treated as text. This adds a check to ensure only characters in the Latin range (U+0000-U+00FF) are treated as text, excluding C1 control characters (U+0080-U+009F). Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2719 +/- ##
==========================================
- Coverage 79.25% 79.24% -0.02%
==========================================
Files 664 664
Lines 52845 52882 +37
Branches 734 734
==========================================
+ Hits 41882 41905 +23
- Misses 10883 10897 +14
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryanmelt
requested changes
Jan 8, 2026
ryanmelt
approved these changes
Jan 9, 2026
Co-Authored-By: Claude Opus 4.5 <[email protected]>
ryanmelt
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary data like 0xDEAD that happens to be valid UTF-8 (decodes to U+07AD Thaana script) was incorrectly being treated as text. This adds a check to ensure only characters in the Latin range (U+0000-U+00FF) are treated as text, excluding C1 control characters (U+0080-U+009F).
Note: this issue is causing the failure in the Enterprise playwright test
command-queue.spec.ts