Skip to content

Config parser updates and notebook setup#2708

Merged
jmthomas merged 6 commits intomainfrom
config_parser_updates_and_notebook_setup
Jan 9, 2026
Merged

Config parser updates and notebook setup#2708
jmthomas merged 6 commits intomainfrom
config_parser_updates_and_notebook_setup

Conversation

@ryanmelt
Copy link
Copy Markdown
Member

@ryanmelt ryanmelt commented Jan 5, 2026

Updates config parser to preserve white space when desired.
Other refactoring to support notebooks.

@ryanmelt ryanmelt requested a review from jmthomas January 5, 2026 05:42
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.25%. Comparing base (00a2db1) to head (bf0593f).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/config/config_parser.rb 92.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2708   +/-   ##
=======================================
  Coverage   79.24%   79.25%           
=======================================
  Files         664      664           
  Lines       52825    52872   +47     
  Branches      734      734           
=======================================
+ Hits        41860    41902   +42     
- Misses      10885    10890    +5     
  Partials       80       80
Flag Coverage Δ
python 81.17% <ø> (+<0.01%) ⬆️
ruby-api 84.76% <ø> (-0.06%) ⬇️
ruby-backend 82.16% <92.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jmthomas
jmthomas requested changes Jan 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have a lot of failing tests

openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/Openc3Screen.vue
getScreenValues: function () {
// Return a copy of the current screen values
return JSON.parse(JSON.stringify(this.screenValues))
},
Copy link
Copy Markdown
Member

@jmthomas jmthomas Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be useful for the "download screeen values" ticket: #1258

@ryanmelt
Copy link
Copy Markdown
Member Author

ryanmelt commented Jan 9, 2026

@jmthomas This is ready to merge as long as the tests pass.

@jmthomas
Copy link
Copy Markdown
Member

jmthomas commented Jan 9, 2026

Did you have to make any other adjustments to Core to support the various bugs we were seeing in Enterprise for Notebooks? Specifically the filename thing where you couldn't transition from ruby to python in a script?

@jmthomas jmthomas merged commit 1e5305c into main Jan 9, 2026
47 checks passed
@jmthomas jmthomas deleted the config_parser_updates_and_notebook_setup branch January 9, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmthomas jmthomas jmthomas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryanmelt @jmthomas