Skip to content

Data extractor log extra in decom#2706

Merged
clayandgen merged 4 commits intomainfrom
data-extractor-username
Jan 5, 2026
Merged

Data extractor log extra in decom#2706
clayandgen merged 4 commits intomainfrom
data-extractor-username

Conversation

@clayandgen
Copy link
Copy Markdown
Contributor

command_decom_topic

  • Ensure that the extra (username of command sender and approver of commands) is properly saved to log files
  • This ensures that when Data Extractor extracts old (not in redis-ephemeral) commands, the username/approver is added

packet.rb

  • If the output of a string telemetry item is a frozen string literal, the << will throw an error as it is trying to manipulate a frozen literal. By returning a formatted string this error is avoided
  • Not an issue in python

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.23%. Comparing base (53d47aa) to head (496c223).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2706      +/-   ##
==========================================
- Coverage   79.31%   79.23%   -0.09%     
==========================================
  Files         662      664       +2     
  Lines       52588    52827     +239     
  Branches      734      734              
==========================================
+ Hits        41710    41856     +146     
- Misses      10798    10891      +93     
  Partials       80       80              
Flag Coverage Δ
python 81.14% <ø> (-0.25%) ⬇️
ruby-api 84.76% <ø> (-0.06%) ⬇️
ruby-backend 82.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clayandgen clayandgen merged commit b816cd1 into main Jan 5, 2026
27 of 28 checks passed
@clayandgen clayandgen deleted the data-extractor-username branch January 5, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants