Merged
Conversation
Add a new Time Format setting in Admin Settings that allows users to choose between 12-hour (AM/PM) and 24-hour time display format for all time pickers in COSMOS. Changes: - Add TimeFormatSettings.vue component in Admin Settings tab - Create OpenC3TimePicker.vue component that respects the global setting - Replace all v-text-field type="time" inputs with OpenC3TimePicker - Support both direct text input and visual clock picker - Parse both 24-hour (HH:mm:ss) and 12-hour (HH:mm:ss AM/PM) input formats Affected tools: Data Viewer, Data Extractor, Telemetry Viewer, Calendar (Activities, Notes, Metadata), Graph Edit Dialog, TimeWidget 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
Author
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
==========================================
- Coverage 79.31% 78.27% -1.04%
==========================================
Files 662 473 -189
Lines 52588 34164 -18424
Branches 734 734
==========================================
- Hits 41708 26743 -14965
+ Misses 10800 7341 -3459
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clayandgen
approved these changes
Jan 2, 2026
Contributor
clayandgen
left a comment
clayandgen
left a comment
There was a problem hiding this comment.
Took a bit of time to get used to it, but I like it!
Looks like Command History and Log Explorer use a different time picker -- I can add a follow-up ticket after this one is merged. I do like the time picker in Command History, but I don't think it supports 24 hr format.
I think we can say this one also closes #2268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1812
Closes #2268
OpenC3TimePickercomponent that respects the global setting and replaces all native HTML5 time inputsAffected tools: Data Viewer, Data Extractor, Telemetry Viewer, Calendar (Activities, Notes, Metadata), Graph Edit Dialog, TimeWidget
Test plan
🤖 Generated with Claude Code