Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v7.0.0 #2687 +/- ##
==================================================
- Coverage 78.31% 78.28% -0.04%
==================================================
Files 473 473
Lines 34073 34283 +210
Branches 734 734
==================================================
+ Hits 26685 26838 +153
- Misses 7308 7365 +57
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Are there any implications to the openc3-redis-v volume? Are they fully backwards compatible?
If you're confident on valkey's future vs Redis with their existing AGPL license then I'm good. Seems like Redis is courting the AI/ML space while ValKey is more focused on clustering and performance. I think the later more fits our use-case.
| RUN ["chmod", "-R", "777", "/home/data/"] | ||
|
|
||
| EXPOSE 6379 | ||
| EXPOSE 6380 |
There was a problem hiding this comment.
Base only exposes 6380, why expose 6379?
There was a problem hiding this comment.
We use 6380 for ephemeral and 6379 for regular. 6379 was exposed in the Redis dockerfile.
2 participants
This is a minimal change with the word Redis still everywhere.
We can open another ticket to change the name to something more generic like "keyvalue" if we want.