Skip to content

Fix all ESLint warnings across Vue packages#2682

Merged
ryanmelt merged 2 commits intomainfrom
linter
Dec 24, 2025
Merged

Fix all ESLint warnings across Vue packages#2682
ryanmelt merged 2 commits intomainfrom
linter

Conversation

@jmthomas
Copy link
Copy Markdown
Member

  • Add missing emits declarations for Vue 3 compatibility
  • Add default prop values and type annotations
  • Fix computed property side effects (refactored to avoid mutations)
  • Replace deprecated Vuetify 2 patterns (v-list-item-icon, transition prop)
  • Replace deprecated Vue 2 API ($delete) with Vue 3 equivalent
  • Fix template shadow variable names
  • Add eslint-disable comments for intentional console.log/error usage
  • Update eslint.yml workflow to enforce 0 warnings for all packages
  • Configure VS Code for auto-format and lint on save

🤖 Generated with Claude Code

- Add missing emits declarations for Vue 3 compatibility
- Add default prop values and type annotations
- Fix computed property side effects (refactored to avoid mutations)
- Replace deprecated Vuetify 2 patterns (v-list-item-icon, transition prop)
- Replace deprecated Vue 2 API ($delete) with Vue 3 equivalent
- Fix template shadow variable names
- Add eslint-disable comments for intentional console.log/error usage
- Update eslint.yml workflow to enforce 0 warnings for all packages
- Configure VS Code for auto-format and lint on save

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
</v-list-item-title>
<div v-html="sanitizeNews(news.body)"></div>
<!-- eslint-disable-next-line vue/no-v-html -->
<div v-html="sanitizeNews(newsItem.body)"></div>
Copy link
Copy Markdown
Contributor

@aikido-pr-checks aikido-pr-checks bot Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using v-html in Vue templates can lead to XSS attacks - high severity
Using v-html can allow attacks to insert HTML into your page, or even scripts if you don't have strict CSP rules set up. Worst case, it could be used as a way to start a social engineering attack or start an account takeover attack.

Remediation: Avoid v-html usage. Ignore this issue only if the HTML content you feed into it is static. Defend in depth against XSS attacks by using a strict CSP policy. If you must use HTML, sanitize it with a library such as DOMPurify.
View details in Aikido Security

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.25%. Comparing base (84f00f5) to head (c82386c).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2682   +/-   ##
=======================================
  Coverage   79.25%   79.25%           
=======================================
  Files         662      662           
  Lines       52419    52417    -2     
  Branches      734      734           
=======================================
+ Hits        41544    41545    +1     
+ Misses      10795    10792    -3     
  Partials       80       80           
Flag Coverage Δ
python 81.26% <ø> (+0.01%) ⬆️
ruby-api 84.43% <ø> (ø)
ruby-backend 82.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryanmelt ryanmelt merged commit d347d45 into main Dec 24, 2025
46 of 47 checks passed
@ryanmelt ryanmelt deleted the linter branch December 24, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants