Skip to content

Add styles and include tool-base in build#2677

Merged
jmthomas merged 2 commits intomainfrom
base_style
Dec 23, 2025
Merged

Add styles and include tool-base in build#2677
jmthomas merged 2 commits intomainfrom
base_style

Conversation

@jmthomas
Copy link
Copy Markdown
Member

This allows us to use tool-base in the Enterprise build and eliminate a lot of duplicate styles

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.25%. Comparing base (db71e0b) to head (16c0be3).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2677      +/-   ##
==========================================
- Coverage   79.25%   79.25%   -0.01%     
==========================================
  Files         662      662              
  Lines       52419    52419              
  Branches      734      734              
==========================================
- Hits        41547    41546       -1     
- Misses      10792    10793       +1     
  Partials       80       80              
Flag Coverage Δ
python 81.27% <ø> (-0.01%) ⬇️
ruby-api 84.43% <ø> (ø)
ruby-backend 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix playwright

@ryan-pratt
Copy link
Copy Markdown
Contributor

Test is failing because the CSS change made this menu wider, so it now covers the entire target dropdown. There used to be a small portion of it visible/clickable.

image

@jmthomas jmthomas requested a review from ryanmelt December 23, 2025 20:33
@jmthomas jmthomas merged commit 6533e4c into main Dec 23, 2025
47 checks passed
@jmthomas jmthomas deleted the base_style branch December 23, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants