Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
==========================================
+ Coverage 79.25% 79.32% +0.07%
==========================================
Files 662 662
Lines 52419 52433 +14
Branches 734 734
==========================================
+ Hits 41547 41595 +48
+ Misses 10792 10758 -34
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryanmelt
requested changes
Dec 23, 2025
| APPEND_PARAMETER ITEM1 16 UINT MIN MAX 101 "Int Item 2" | ||
| KEY $.item1 | ||
| UNITS CELSIUS C | ||
| OVERLAP |
Member
There was a problem hiding this comment.
These aren't overlapped. Why mark OVERLAP?
Member
Author
There was a problem hiding this comment.
I think I was seeing this overlap before I fixed the ordering ... will fix
Member
Author
There was a problem hiding this comment.
Actual issue was that structure items with parent_item should not be included in the bit offset overlap calculation because they share the same bit offset
ryanmelt
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation in
openc3/python/openc3/packets/structure_item.pydid not match that of the Ruby version and theOVERLAPflag on theITEM BYTESin theINST2 IMAGEpacket was still showing up as a bit overlap warning. This was fixed along with a bunch of additional unit tests that claude created.