Skip to content

Enforce RBAC in Bucket Explorer#2666

Merged
jmthomas merged 1 commit intomainfrom
bucket_rbac
Dec 29, 2025
Merged

Enforce RBAC in Bucket Explorer#2666
jmthomas merged 1 commit intomainfrom
bucket_rbac

Conversation

@jmthomas
Copy link
Copy Markdown
Member

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 96.73913% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.28%. Comparing base (6ba6d17) to head (4a60f27).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...-cmd-tlm-api/app/controllers/storage_controller.rb 96.73% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2666      +/-   ##
==========================================
+ Coverage   79.25%   79.28%   +0.03%     
==========================================
  Files         662      662              
  Lines       52412    52512     +100     
  Branches      734      734              
==========================================
+ Hits        41539    41635      +96     
- Misses      10793    10797       +4     
  Partials       80       80              
Flag Coverage Δ
python 81.27% <ø> (+<0.01%) ⬆️
ruby-api 84.72% <96.73%> (+0.23%) ⬆️
ruby-backend 82.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@clayandgen clayandgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated with a custom role with tlm access to SENSOR_KIT only, and installed 4 plugins total to the "TEST" scope.
Screenshot 2025-12-29 at 10 21 21 AM
4 plugins installed to TEST scope
Screenshot 2025-12-29 at 10 20 57 AM
Only 1 viewable when RBAC enforced on my tester user with custom role with tlm access to only SENSOR_KIT
Screenshot 2025-12-29 at 10 20 49 AM

@jmthomas jmthomas merged commit 130562c into main Dec 29, 2025
28 checks passed
@jmthomas jmthomas deleted the bucket_rbac branch December 29, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants