[Feature] Add Username/Approver to the Command Export#2648
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2648 +/- ##
==========================================
+ Coverage 79.23% 79.25% +0.01%
==========================================
Files 662 662
Lines 52407 52412 +5
Branches 734 734
==========================================
+ Hits 41524 41537 +13
+ Misses 10803 10795 -8
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| release_critical = True | ||
| else: | ||
| return f"Critical command {msg_hash[b'release_critical'].decode()} not found" | ||
| return "SUCCESS" |
There was a problem hiding this comment.
@jmthomas -- This seemed like a bug, as it's not in the interface_microservice.rb and it short-circuits
There was a problem hiding this comment.
Agreed. There must have been a side effect. Were commands not released in Python?
There was a problem hiding this comment.
Do we need better unit tests for this?
jmthomas
left a comment
jmthomas
left a comment
There was a problem hiding this comment.
See if you can resolve the eslint error.
| release_critical = True | ||
| else: | ||
| return f"Critical command {msg_hash[b'release_critical'].decode()} not found" | ||
| return "SUCCESS" |
There was a problem hiding this comment.
Do we need better unit tests for this?
2 participants
closes #2286
Adds the username and approver details of a sent command in the _extra field, to be used in the Data Extractor and Command History tools.