Fix Python System.telemetry.value with LATEST#2641
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
+ Coverage 79.08% 79.21% +0.12%
==========================================
Files 661 662 +1
Lines 51989 52182 +193
Branches 732 732
==========================================
+ Hits 41118 41334 +216
+ Misses 10791 10768 -23
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmthomas
approved these changes
Dec 16, 2025
Member
jmthomas
left a comment
jmthomas
left a comment
There was a problem hiding this comment.
Should some of these simply be deprecated?
| @@ -324,6 +383,22 @@ def reset(self) -> None: | |||
| for _, packet in packets.items(): | |||
| packet.reset() | |||
|
|
|||
| # Returns an array with a "TARGET_NAME PACKET_NAME ITEM_NAME" string for every item in the system | |||
| def all_item_strings(self, include_hidden = False, _splash = None): | |||
Member
There was a problem hiding this comment.
Where is this called? I can't even find where it's called in the Ruby code.
| # @param target_name (see #packet) | ||
| # @param packet_name (see #packet) The packet name. LATEST is supported. | ||
| # @return [Array<PacketItem>] The telemetry item names for the given target and packet name | ||
| def item_names(self, target_name, packet_name): |
Member
There was a problem hiding this comment.
Where is this called? I can't even find where it's called in the Ruby code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.