Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
+ Coverage 79.07% 79.11% +0.03%
==========================================
Files 661 662 +1
Lines 51990 52140 +150
Branches 732 732
==========================================
+ Hits 41111 41250 +139
- Misses 10799 10810 +11
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| def write(self, string): | ||
| # Can't use isoformat because it appends "+00:00" instead of "Z" | ||
| self._report.append(datetime.now(timezone.utc).strftime("%Y-%m-%dT%H:%M:%S.%fZ") + ": " + string) | ||
| # Get time_zone setting to determine timestamp format |
There was a problem hiding this comment.
This is pointless because the timezone is always UTC on the backend. Is this what is being done in ruby?
There was a problem hiding this comment.
No, we're just using the backend UTC time but I think it would be better to use the user's setting. For most stuff that's all in the frontend but here we have to check because it's a backend process formatting the file.
There was a problem hiding this comment.
The backend doesn't know what the local timezone is, so it can't do anything different.
There was a problem hiding this comment.
ahh right ... it's just 'local' ... ok will revert ... this was claude's attempt at doing something lol
| @@ -75,7 +75,6 @@ spec = Gem::Specification.new do |s| | |||
| s.files = Dir.glob("{bin,data,ext,lib,spec,tasks,templates,test}/**/*", File::FNM_DOTMATCH) + %w(Gemfile Guardfile LICENSE.txt Rakefile README.md) | |||
|
|
|||
| # Runtime Dependencies | |||
| s.add_runtime_dependency 'bundler', '~> 2.3' | |||
There was a problem hiding this comment.
This snuck in here but I'm going to remove it in a dependencies update as well. It is broken now that Bundler is 4.0.
2 participants
Without this change the HYBRIDTLM packet won't display any values for JSON.ITEM5 or CBOR.ITEM5. Also the default values for IITEM5 in both the JSONCMD and CBORCMD are empty.