Skip to content

Extended types#2597

Merged
ryanmelt merged 8 commits intomainfrom
extended_types
Dec 8, 2025
Merged

Extended types#2597
ryanmelt merged 8 commits intomainfrom
extended_types

Conversation

@ryanmelt
Copy link
Copy Markdown
Member

@ryanmelt ryanmelt commented Dec 4, 2025

Adds BOOL, OBJECT, ARRAY, and ANY as fully supported types.
These are only useful with non-binary accessor accessors.

@ryanmelt ryanmelt requested a review from jmthomas December 4, 2025 15:42
jmthomas
jmthomas reviewed Dec 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments in the Ruby code apply to the Python code

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 72.28916% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.08%. Comparing base (2756bc5) to head (2675c49).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...3/lib/openc3/packets/parsers/packet_item_parser.rb 73.68% 15 Missing ⚠️
openc3/lib/openc3/packets/packet.rb 42.85% 4 Missing ⚠️
...nc3/lib/openc3/tools/table_manager/table_config.rb 0.00% 3 Missing ⚠️
...penc3/lib/openc3/packets/parsers/xtce_converter.rb 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
- Coverage   79.10%   79.08%   -0.03%     
==========================================
  Files         661      661              
  Lines       51819    51995     +176     
  Branches      734      734              
==========================================
+ Hits        40994    41122     +128     
- Misses      10745    10793      +48     
  Partials       80       80
Flag Coverage Δ
python 81.05% <ø> (-0.05%) ⬇️
ruby-api 84.48% <ø> (+0.05%) ⬆️
ruby-backend 82.05% <72.28%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthomas jmthomas self-requested a review December 5, 2025 13:03
jmthomas
jmthomas requested changes Dec 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the main merge broke the eslint changes I made but it's fine for now. We can tackle those warnings in future commits.

You need to update _command.md, _conversions.md, _table.md, and _telemetry.md. Look for INT, UINT and add your new types.

@jmthomas jmthomas self-requested a review December 5, 2025 18:10
@ryanmelt ryanmelt merged commit 02b93c6 into main Dec 8, 2025
46 of 47 checks passed
@ryanmelt ryanmelt deleted the extended_types branch December 8, 2025 03:36
This was referenced Dec 26, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmthomas jmthomas jmthomas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryanmelt @jmthomas