Skip to content

Verify python protocols support hex strings#2587

Merged
mcosgriff merged 2 commits intomainfrom
2586-python-protocols-support-hex-strings
Dec 2, 2025
Merged

Verify python protocols support hex strings#2587
mcosgriff merged 2 commits intomainfrom
2586-python-protocols-support-hex-strings

Conversation

@mcosgriff
Copy link
Copy Markdown
Contributor

@mcosgriff mcosgriff commented Dec 2, 2025 •
edited
Loading

Formatting

Ran poetry run ruff format openc3/interfaces/protocols and poetry run ruff format test/interfaces/protocols

Test All Hex String Tests

cd openc3/python
poetry run pytest test/interfaces/protocols/ -k "hex_string" -v

Individual Protocol Tests

cd openc3/python

# BurstProtocol (2 tests)
poetry run pytest test/interfaces/protocols/test_burst_protocol.py -k "hex_string" -v

# CrcProtocol (4 tests)
poetry run pytest test/interfaces/protocols/test_crc_protocol.py -k "hex_string" -v

# FixedProtocol (1 test)
poetry run pytest test/interfaces/protocols/test_fixed_protocol.py -k "hex_string" -v

# LengthProtocol (5 tests)
poetry run pytest test/interfaces/protocols/test_length_protocol.py -k "hex_string" -v

# TemplateProtocol (2 tests)
poetry run pytest test/interfaces/protocols/test_template_protocol.py -k "hex_string" -v

# Preidentified Protocol (1 test)
# This will fail without redis running
poetry run pytest test/interfaces/protocols/test_preidentified_protocol.py -k "hex_string" -v

Closes #2586

@mcosgriff mcosgriff linked an issue Dec 2, 2025 that may be closed by this pull request
Python protocols support hex strings #2586
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.13%. Comparing base (f3c3832) to head (7f009e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2587      +/-   ##
==========================================
+ Coverage   79.12%   79.13%   +0.01%     
==========================================
  Files         663      663              
  Lines       51800    51806       +6     
  Branches      735      735              
==========================================
+ Hits        40988    40998      +10     
+ Misses      10732    10728       -4     
  Partials       80       80
Flag Coverage Δ
python 81.13% <ø> (+0.04%) ⬆️
ruby-api 84.41% <ø> (-0.08%) ⬇️
ruby-backend 82.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcosgriff mcosgriff marked this pull request as ready for review December 2, 2025 16:50
jmthomas
jmthomas approved these changes Dec 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the formatting. :-)

@mcosgriff mcosgriff merged commit 560e10f into main Dec 2, 2025
31 checks passed
@mcosgriff mcosgriff deleted the 2586-python-protocols-support-hex-strings branch December 2, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmthomas jmthomas jmthomas approved these changes

@EmilyRagan EmilyRagan Awaiting requested review from EmilyRagan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python protocols support hex strings

2 participants

@mcosgriff @jmthomas