Conversation
jmthomas
requested review from
EmilyRagan,
clayandgen,
mcosgriff and
ryan-pratt
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
- Coverage 79.17% 79.13% -0.05%
==========================================
Files 662 663 +1
Lines 51305 51800 +495
Branches 735 735
==========================================
+ Hits 40622 40993 +371
- Misses 10603 10727 +124
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clayandgen
left a comment
clayandgen
left a comment
There was a problem hiding this comment.
I'm guessing type was reserved for python?
mcosgriff
left a comment
mcosgriff
left a comment
There was a problem hiding this comment.
It wasn't working because we were using a the name of a built-in?
|
@clayandgen @mcosgriff the name of the parameter was changed in another PR https://github.com/OpenC3/cosmos-enterprise/pull/344/files#diff-e700817f1e9efce35cfc1e31eda25040a9acd36f32eaccd3d65d8ac8843a7ee0 |
|
Yeah I broke it while doing an update to fix the build-in shadow as recommended by SonarQube. |
4 participants
closes #2539
I'd also like to create a playwright test for this in Enterprise