Skip to content

move tooltip to card header so that it is visible again#2582

Merged
jmthomas merged 1 commit intomainfrom
2572_packet-viewer-info
Dec 2, 2025
Merged

move tooltip to card header so that it is visible again#2582
jmthomas merged 1 commit intomainfrom
2572_packet-viewer-info

Conversation

@EmilyRagan
Copy link
Copy Markdown
Contributor

Closes #2572

@EmilyRagan EmilyRagan requested a review from jmthomas December 1, 2025 22:23
@EmilyRagan EmilyRagan self-assigned this Dec 1, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.12%. Comparing base (2039b05) to head (8972305).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2582      +/-   ##
==========================================
- Coverage   79.13%   79.12%   -0.01%     
==========================================
  Files         663      663              
  Lines       51800    51800              
  Branches      735      735              
==========================================
- Hits        40991    40987       -4     
- Misses      10729    10733       +4     
  Partials       80       80              
Flag Coverage Δ
python 81.08% <ø> (-0.03%) ⬇️
ruby-api 84.46% <ø> (-0.03%) ⬇️
ruby-backend 82.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EmilyRagan
Copy link
Copy Markdown
Contributor Author

EmilyRagan commented Dec 1, 2025

Personally I really dislike the close-delay on this tooltip, but not enough to have a discussion about it right now, since this should be merged before the upcoming 6.10 release, as it resolves an issue introduced by a change that will be in 6.10

Copy link
Copy Markdown
Contributor

@clayandgen clayandgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, mind adding a screenshot on these types of PRs? Helps provide some more context :) Thanks!

@jmthomas
Copy link
Copy Markdown
Member

jmthomas commented Dec 2, 2025

Screenshot 2025-12-01 at 5 18 57 PM

@jmthomas jmthomas merged commit 377b4ff into main Dec 2, 2025
50 of 54 checks passed
@jmthomas jmthomas deleted the 2572_packet-viewer-info branch December 2, 2025 00:19
ryan-pratt pushed a commit that referenced this pull request Dec 2, 2025
move tooltip to card header so that it is visible again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add back info icon on Packet Viewer

3 participants