Skip to content

Quest setup#2578

Merged
jmthomas merged 4 commits intorelease/v7.0.0from
quest_setup
Dec 13, 2025
Merged

Quest setup#2578
jmthomas merged 4 commits intorelease/v7.0.0from
quest_setup

Conversation

@jmthomas
Copy link
Copy Markdown
Member

@jmthomas jmthomas commented Nov 27, 2025 •
edited
Loading

Only changes to review are in tsdb_microservice.py

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.64%. Comparing base (f5f01a3) to head (1d67f11).
⚠️ Report is 217 commits behind head on release/v7.0.0.

Additional details and impacted files 
@@                Coverage Diff                 @@
##           release/v7.0.0    #2578      +/-   ##
==================================================
- Coverage           79.58%   78.64%   -0.95%     
==================================================
  Files                 658      472     -186     
  Lines               50412    33029   -17383     
  Branches              736      736              
==================================================
- Hits                40121    25975   -14146     
+ Misses              10211     6974    -3237     
  Partials               80       80
Flag Coverage Δ
python 96.03% <ø> (+14.50%) ⬆️
ruby-api 84.32% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 27, 2025 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@clayandgen
Copy link
Copy Markdown
Contributor

clayandgen commented Dec 1, 2025

Any chance we can merge main into release/v7.0.0, and then checkout this branch to have this PR just contain the relevant QuestDB changes? Challenging to read through the changes... Thanks!

clayandgen
clayandgen reviewed Dec 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@clayandgen clayandgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely don't remove columns if the new tlm definition removes an item? That's probably intentional to hold onto historical info, if exists

openc3-tsdb/Dockerfile
ENV REQUESTS_CA_BUNDLE=/devel/cacert.pem
ENV NODE_EXTRA_CA_CERTS=/devel/cacert.pem
# Configure QuestDB environment variables for performance tuning
ENV QDB_CAIRO_WRITER_DATA_APPEND_PAGE_SIZE=64K
Copy link
Copy Markdown
Contributor

@clayandgen clayandgen Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member Author

@jmthomas jmthomas Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we will keep all old columns so we have the historical data

Copy link
Copy Markdown
Contributor

@clayandgen clayandgen Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://questdb.slack.com/archives/C1NFJEER0/p1764890948000829?thread_ts=1764114468.258889&cid=C1NFJEER0

I observed some ~10% decrease in size after adjusting cairo.writer.data.index.value.append.page.size to 128k. Just thought this is good info :)

@jmthomas jmthomas merged commit 997156a into release/v7.0.0 Dec 13, 2025
15 of 20 checks passed
@jmthomas jmthomas deleted the quest_setup branch December 13, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clayandgen clayandgen clayandgen left review comments

@ryanmelt ryanmelt Awaiting requested review from ryanmelt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmthomas @clayandgen