Skip to content

[Enhancement] Table Manager usability#2574

Merged
clayandgen merged 2 commits intomainfrom
bug/table-manager
Dec 2, 2025
Merged

[Enhancement] Table Manager usability#2574
clayandgen merged 2 commits intomainfrom
bug/table-manager

Conversation

@clayandgen
Copy link
Copy Markdown
Contributor

closes #2329
closes #1729

  • Removed the "auto-report saving" mechanism on report download
  • Renamed "New file" to "New Binary from Definition" to reflect true behavior better
Screenshot 2025-11-26 at 2 09 53 PM
  • Added clear messaging to reflect true behavior
Screenshot 2025-11-26 at 2 10 01 PM
  • Added a confirmation dialog when the "new" flow is selected to ensure that files are not overwritten on accident
Screenshot 2025-11-26 at 2 10 10 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.13%. Comparing base (7fc0efe) to head (03f0281).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
- Coverage   79.17%   79.13%   -0.05%     
==========================================
  Files         662      663       +1     
  Lines       51305    51798     +493     
  Branches      735      735              
==========================================
+ Hits        40622    40990     +368     
- Misses      10603    10728     +125     
  Partials       80       80              
Flag Coverage Δ
python 81.11% <ø> (-0.19%) ⬇️
ruby-api 84.48% <ø> (+0.07%) ⬆️
ruby-backend 82.13% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filename is showing up with a * to indicate modified even after I create new. It should clear this when creating new. Actually it looks like it always has the *. Fix this and I think it's good.

@clayandgen clayandgen merged commit 801c024 into main Dec 2, 2025
49 of 50 checks passed
@clayandgen clayandgen deleted the bug/table-manager branch December 2, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table manager file options don't work as expected Table Manager download report creates file in bucket storage

2 participants