Keep menu open when submenu is clicked#2554
Merged
EmilyRagan merged 4 commits intomainfrom Nov 19, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
==========================================
- Coverage 79.19% 79.19% -0.01%
==========================================
Files 661 661
Lines 51215 51215
Branches 736 736
==========================================
- Hits 40561 40558 -3
- Misses 10574 10577 +3
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
44c96cb to
141591c
Compare
141591c to
a9387ba
Compare
clayandgen
approved these changes
Nov 19, 2025
Contributor
clayandgen
left a comment
There was a problem hiding this comment.
Behavior confirmed on the UI via Script Runner's top bar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2514
Extracted the
v-menuportion of the template to a separate component so that a ref could be created to use as thev-modelvalue for that menu in order to programmatically change its state. Created this new component using the<script setup>syntax that is native to Composition API. This is fully supported to be used in conjunction with Options APIChanges that actually address the click behavior can be seen in this commit