Merged
Conversation
Contributor
|
The scroll bar goes up to the top of the header when it should just be over the table items, but I'm pretty sure this is a vuetify issue 
|
ryan-pratt
approved these changes
Nov 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2547 +/- ##
=======================================
Coverage 79.19% 79.20%
=======================================
Files 661 661
Lines 51215 51214 -1
Branches 736 736
=======================================
+ Hits 40561 40562 +1
+ Misses 10574 10572 -2
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmilyRagan
force-pushed
the
2523_packet-viewer-virtual-table
branch
4 times, most recently
from
9a9b328 to
54387a6
Compare
EmilyRagan
force-pushed
the
2523_packet-viewer-virtual-table
branch
from
54387a6 to
b09ccbb
Compare
ryan-pratt
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2523
Attached gem contains plugin with target that has 13,667 items defined. This is enough that it may crash the page with the current implementation of PacketViewer when using the "all" option. It should not crash the page and should perform nicely with this new implementation using a virtualized data table.
The number of HTML elements in the table body when viewing all with the previous implementation would always equal the number of items defined. With the implementation on this branch, the number of HTML elements in the table body should be only a handful more than what is visible on the page at any given time.
Decisions about changes to UI:
Created
composables/inopenc3-vue-common-- this is the Vue Composition API equivalent to mixins. Since I had already implemented thecontainerHeightcomputed value in ScriptRunner and needed the same value for PacketViewer, I decided to move this into a composable to share the code, especially because I expect it'll be useful in other tools in the future. Since composables are a Composition API thing, they must be used insetup()if not using<script setup>