Skip to content

Interpret environment variable value as boolean instead of string#2544

Merged
EmilyRagan merged 1 commit intomainfrom
environment-variable-helpers
Nov 19, 2025
Merged

Interpret environment variable value as boolean instead of string#2544
EmilyRagan merged 1 commit intomainfrom
environment-variable-helpers

Conversation

@EmilyRagan
Copy link
Copy Markdown
Contributor

  • Add helper methods for Ruby and Python to interpret an environment variable value into a boolean (1, Yes, True, On as true, all else as false)
  • Use helper method to read OPENC3_LOG_STDERR, especially for use in log_message
  • Adjust implementation of log_message to reduce duplication and improve clarity
  • Add unit tests for log_message (generated by Claude)

@EmilyRagan EmilyRagan self-assigned this Nov 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.63%. Comparing base (eebbd39) to head (9fcf41e).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/utilities/env_helper.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2544      +/-   ##
==========================================
+ Coverage   79.61%   79.63%   +0.02%     
==========================================
  Files         658      659       +1     
  Lines       50465    50469       +4     
  Branches      736      736              
==========================================
+ Hits        40176    40192      +16     
+ Misses      10209    10197      -12     
  Partials       80       80              
Flag Coverage Δ
python 81.65% <ø> (+0.05%) ⬆️
ruby-api 84.51% <ø> (-0.03%) ⬇️
ruby-backend 82.95% <91.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EmilyRagan EmilyRagan marked this pull request as ready for review November 14, 2025 21:47
@EmilyRagan EmilyRagan requested a review from ryanmelt November 14, 2025 21:47
@EmilyRagan EmilyRagan merged commit c86180b into main Nov 19, 2025
29 of 30 checks passed
@EmilyRagan EmilyRagan deleted the environment-variable-helpers branch November 19, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants