Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
- Coverage 79.21% 79.16% -0.06%
==========================================
Files 662 662
Lines 51218 51301 +83
Branches 736 735 -1
==========================================
+ Hits 40573 40613 +40
- Misses 10565 10608 +43
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@clayandgen you need to be using this PR from Enterprise to test the changes: https://github.com/OpenC3/cosmos-enterprise/pull/362 |
| # This handles data from hex_to_byte_string and other binary sources | ||
| if self.encoding == Encoding::ASCII_8BIT && self.bytes.any? { |b| b > 127 } | ||
| return self.to_json_raw_object | ||
| end |
There was a problem hiding this comment.
This was actually important to getting a command like cmd("INST MEMLOAD with DATA 0xDEAD") to work
There was a problem hiding this comment.
Actually sorry, I don't think the behavior for the editable command history with queue=False is working as intended. This puts the command back on the queue, and I have +OPENC3_DEFAULT_QUEUE=DEFAULT set in my .env. The change is probably for the enterprise repo
clayandgen
left a comment
clayandgen
left a comment
There was a problem hiding this comment.
Command queue selection looks good -- verified #2521
The change in PR #2535 to support binary commands incorrectly encoded valid UTF-8 Unicode characters (e.g., µA for micro-Ampères) as raw byte arrays. This was caused by an overly aggressive early return that treated all ASCII-8BIT strings with bytes > 127 as binary data. The fix removes this early return and relies on UTF-8 validity checking to distinguish between true binary data (invalid UTF-8) and Unicode text (valid UTF-8 stored in ASCII-8BIT strings). Added regression tests for both Ruby and Python to prevent future issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
2 participants
closes #2520
closes #2521