Skip to content

2472 | get_target_file now returns None/nil when file is not found#2519

Merged
EmilyRagan merged 5 commits intorelease/v7.0.0from
2472_get-target-file-exception-logic
Nov 25, 2025
Merged

2472 | get_target_file now returns None/nil when file is not found#2519
EmilyRagan merged 5 commits intorelease/v7.0.0from
2472_get-target-file-exception-logic

Conversation

@EmilyRagan
Copy link
Copy Markdown
Contributor

@EmilyRagan EmilyRagan commented Nov 8, 2025

Closes #2472

@EmilyRagan EmilyRagan self-assigned this Nov 8, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.70%. Comparing base (f5f01a3) to head (3ff5fa0).
⚠️ Report is 7 commits behind head on release/v7.0.0.

Additional details and impacted files 
@@                Coverage Diff                 @@
##           release/v7.0.0    #2519      +/-   ##
==================================================
+ Coverage           79.58%   79.70%   +0.11%     
==================================================
  Files                 658      658              
  Lines               50412    50412              
  Branches              736      736              
==================================================
+ Hits                40121    40179      +58     
+ Misses              10211    10153      -58     
  Partials               80       80
Flag Coverage Δ
python 81.78% <ø> (+0.24%) ⬆️
ruby-api 84.49% <ø> (ø)
ruby-backend 82.99% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EmilyRagan EmilyRagan force-pushed the 2472_get-target-file-exception-logic branch from 54905a4 to 999117b Compare November 8, 2025 00:13
@jmthomas
Copy link
Copy Markdown
Member

jmthomas commented Nov 9, 2025

Let's merge this to the release/v7.0.0 since it's a breaking change to the API. Otherwise looks good!

@EmilyRagan EmilyRagan changed the base branch from main to release/v7.0.0 November 10, 2025 19:29
@EmilyRagan EmilyRagan marked this pull request as ready for review November 14, 2025 21:56
clayandgen
clayandgen requested changes Nov 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@clayandgen clayandgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I think playwright tests need an update accordingly

@EmilyRagan EmilyRagan mentioned this pull request Nov 24, 2025
Closed
@EmilyRagan
Copy link
Copy Markdown
Contributor Author

EmilyRagan commented Nov 24, 2025

@clayandgen all of the failing Playwright tests are failing on release/v7.0.0 branch, so they were not introduced by the changes here. I've changed them to .fixme and opened #2564 to address the failures

@jmthomas
Copy link
Copy Markdown
Member

jmthomas commented Nov 24, 2025

This one feels like one you need to fix:

Notice:   1 failed
    [chromium] › tests/script-runner/api.s.spec.ts:67:5 › opens a target file ──────────────────────

@EmilyRagan EmilyRagan merged commit 8bb248f into release/v7.0.0 Nov 25, 2025
29 of 30 checks passed
@EmilyRagan EmilyRagan deleted the 2472_get-target-file-exception-logic branch November 25, 2025 16:50
@EmilyRagan EmilyRagan mentioned this pull request Nov 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clayandgen clayandgen clayandgen approved these changes

Assignees

@EmilyRagan EmilyRagan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better exception logic for get_target_file()

3 participants

@EmilyRagan @jmthomas @clayandgen