Skip to content

Start queue_microservice with existing state#2489

Merged
jmthomas merged 4 commits intomainfrom
queue_microservice
Nov 5, 2025
Merged

Start queue_microservice with existing state#2489
jmthomas merged 4 commits intomainfrom
queue_microservice

Conversation

@jmthomas
Copy link
Copy Markdown
Member

@jmthomas jmthomas commented Oct 30, 2025 •
edited
Loading

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.61%. Comparing base (4129e58) to head (f2c3ab1).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...s-cmd-tlm-api/app/controllers/queues_controller.rb 66.66% 4 Missing ⚠️
...nc3/lib/openc3/microservices/queue_microservice.rb 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2489      +/-   ##
==========================================
- Coverage   79.63%   79.61%   -0.03%     
==========================================
  Files         658      658              
  Lines       50420    50457      +37     
  Branches      736      736              
==========================================
+ Hits        40154    40169      +15     
- Misses      10186    10208      +22     
  Partials       80       80
Flag Coverage Δ
python 81.58% <ø> (-0.06%) ⬇️
ruby-api 84.49% <66.66%> (-0.08%) ⬇️
ruby-backend 82.94% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 30, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jmthomas jmthomas requested a review from ryanmelt November 2, 2025 14:26
@EmilyRagan
Copy link
Copy Markdown
Contributor

EmilyRagan commented Nov 3, 2025

@jmthomas what do you think about the other 2 suggestions from OpenC3/cosmos-enterprise#315?

  • Embed selected queue name into url to enable link sharing and page refresh to load same queue
  • Maybe sort the queues in the dropdown alphabetically by default

@jmthomas
Copy link
Copy Markdown
Member Author

jmthomas commented Nov 3, 2025

@jmthomas what do you think about the other 2 suggestions from OpenC3/cosmos-enterprise#315?

  • Embed selected queue name into url to enable link sharing and page refresh to load same queue
  • Maybe sort the queues in the dropdown alphabetically by default

Should be addressed by https://github.com/OpenC3/cosmos-enterprise/pull/333

EmilyRagan
EmilyRagan requested changes Nov 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@EmilyRagan EmilyRagan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior is good! Just need to hide the "queue selection" dropdown from the "add command" modals when in the Command Queue tool

@jmthomas
Copy link
Copy Markdown
Member Author

jmthomas commented Nov 3, 2025

showQueueSelect prop added and implemented in Enterprise here: https://github.com/OpenC3/cosmos-enterprise/pull/344

EmilyRagan
EmilyRagan approved these changes Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@EmilyRagan EmilyRagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally loving the UI here, but it is fine for now. We may want to consider improving this further in the future
image

@jmthomas jmthomas merged commit d42896a into main Nov 5, 2025
48 of 49 checks passed
@jmthomas jmthomas deleted the queue_microservice branch November 5, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilyRagan EmilyRagan EmilyRagan approved these changes

@mcosgriff mcosgriff Awaiting requested review from mcosgriff

@clayandgen clayandgen Awaiting requested review from clayandgen

@ryan-pratt ryan-pratt Awaiting requested review from ryan-pratt

@ryanmelt ryanmelt Awaiting requested review from ryanmelt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmthomas @EmilyRagan