Skip to content

Add eslint to CI#2481

Merged
EmilyRagan merged 10 commits intomainfrom
eslint
Oct 29, 2025
Merged

Add eslint to CI#2481
EmilyRagan merged 10 commits intomainfrom
eslint

Conversation

@EmilyRagan
Copy link
Copy Markdown
Contributor

@EmilyRagan EmilyRagan commented Oct 27, 2025 •
edited
Loading

  • Created a GitHub Actions Workflow for running eslint on relevant packages
    • Each package within cosmos/openc3-cosmos-init/plugins/packages has its own job to run eslint, and each job is only run if there were files changed within that package for a given PR
    • Each package has a separate eslint max-warnings value based on its current number of eslint warnings. This should be decreased over time
  • Centralized dev dependencies related to eslint into the openc3-cosmos-init/plugins/package.json file to take advantage of shared decencies in workspaces
    • There may be other dev dependencies that we can move into the workspace's package file as well, but that is outside the scope of this work
  • Centralized shared eslint config
    • All eslint files were the same, so each package now imports that common configuration from the workspace
    • Some packages had eslint errors, so the base config was extended to override the particular rule that had errors to set that rule to warn instead of error as a temporary measure until the failure is addressed
  • This is not technically doing enforcement of the eslint rules yet, since the workflow is not marked as "required" in the GitHub Actions settings for the repository. Since each job is optional, it may be the case that no eslint job runs (ie: if changes are back-end only), so it should not be marked as required in the current configuration. Another job could be added (and remove the paths filter from the top of this workflow) such that at least one job runs for each PR. This workflow could then be marked as required, thereby enforcing the eslint rules. Other jobs could also be added to run linters on the python and ruby code when that is changed

@EmilyRagan EmilyRagan self-assigned this Oct 27, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.65%. Comparing base (7c92744) to head (60f0b60).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2481      +/-   ##
==========================================
- Coverage   79.66%   79.65%   -0.01%     
==========================================
  Files         658      658              
  Lines       50418    50418              
  Branches      736      736              
==========================================
- Hits        40163    40159       -4     
- Misses      10175    10179       +4     
  Partials       80       80
Flag Coverage Δ
python 81.67% <ø> (-0.03%) ⬇️
ruby-api 84.62% <ø> (ø)
ruby-backend 82.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Oct 27, 2025 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@EmilyRagan EmilyRagan requested a review from ryan-pratt October 28, 2025 14:51
@EmilyRagan EmilyRagan marked this pull request as ready for review October 28, 2025 15:53
@EmilyRagan EmilyRagan requested a review from jmthomas October 28, 2025 15:54
jmthomas
jmthomas approved these changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the consolidation of the rules. I was able to get this integrated with VSCode by manually running pnpm install from the plugins dir.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 29, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@EmilyRagan EmilyRagan merged commit e746b02 into main Oct 29, 2025
49 of 50 checks passed
@EmilyRagan EmilyRagan deleted the eslint branch October 29, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmthomas jmthomas jmthomas approved these changes

@ryan-pratt ryan-pratt Awaiting requested review from ryan-pratt

Assignees

@EmilyRagan EmilyRagan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EmilyRagan @jmthomas