Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2474 +/- ##
==========================================
- Coverage 79.60% 79.37% -0.24%
==========================================
Files 658 660 +2
Lines 50463 50691 +228
Branches 736 736
==========================================
+ Hits 40171 40235 +64
- Misses 10212 10376 +164
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
jmthomas
left a comment
jmthomas
left a comment
There was a problem hiding this comment.
This PR is huge and I love the new auto-detect for unique ID mode. I think we need more docs on this feature and some tie into your FPrime example.
| this.api.get_tlm_values(this.screenItems).then((data) => { | ||
| if (this.availableItems.length !== 0) { | ||
| this.api.get_tlm_values(this.availableItems).then((data) => { | ||
| this.updateValues(data) |
There was a problem hiding this comment.
Is the calculation of available just to optimize this update() method so it doesn't call updateValues() if there are no available items?
There was a problem hiding this comment.
available is required once we implement the time series database. Just getting ahead on that.
| subpackets = packet.subpacketize | ||
|
|
||
| subpackets.each do |subpacket| | ||
| if subpacket.subpacket |
There was a problem hiding this comment.
This feels weird to me ... subpacket.subpacket? Is there ever a time this is nil? Who sets the subpacket of the subpacket? Maybe it's just the variable names ...
There was a problem hiding this comment.
Renamed to packet_and_subpackets, and packet_or_subpacket to clarify.
| packet.ignore_overlap = hash['ignore_overlap'] | ||
|
|
||
| packet | ||
| end |
There was a problem hiding this comment.
Not used anywhere, a bit defective, and hard to maintain.
| parser.verify_num_parameters(0, 0, usage) | ||
| @tlm_unique_id_mode = true | ||
| when 'CMD_UNIQUE_ID_MODE', 'TLM_UNIQUE_ID_MODE' | ||
| # Deprecated - Now autodetected |
There was a problem hiding this comment.
I thought we were going to warn the user if they end up in a UNIQUE_ID_MODE that this is not an optimized telemetry format and they would suffer performance.
There was a problem hiding this comment.
I'm ok with no warning. Sometimes its unavoidable.
| SUBPACKET: | ||
| summary: Marks this packet as as a subpacket which will exclude it from Interface level identification | ||
| description: Used with a SUBPACKETIZER to breakup up packets into subpackets at decom time | ||
| since: 6.10.0 No newline at end of file |
There was a problem hiding this comment.
We need some more docs in the telemetry page to talk about VIRTUAL vs SUBPACKET and when you would use one vs the other. I'm not sure I'm entirely clear on it.
There was a problem hiding this comment.
Will add a new guide page
|
Going to go ahead and merge this. Will do doc updates in a smaller PR. |
2 participants
Subpackets provides a process for breaking up packets during decom into subpackets.
Can be used for channelized telemetry and for packets that are a bunch of samples for the same inherent item.
I'm going to build a plugin for FPrime to further test this before merging.
closes #1168