Skip to content

[Enhancement] Add confirmation on SR on modified file navigation#2465

Merged
clayandgen merged 2 commits intomainfrom
enhancement/sr-warning
Oct 22, 2025
Merged

[Enhancement] Add confirmation on SR on modified file navigation#2465
clayandgen merged 2 commits intomainfrom
enhancement/sr-warning

Conversation

@clayandgen
Copy link
Copy Markdown
Contributor

Screenshot 2025-10-19 at 6 18 15 PM

closes #2343

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.64%. Comparing base (07aa42a) to head (67c3ae4).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2465      +/-   ##
==========================================
- Coverage   79.64%   79.64%   -0.01%     
==========================================
  Files         658      658              
  Lines       50417    50417              
  Branches      736      736              
==========================================
- Hits        40156    40154       -2     
- Misses      10181    10183       +2     
  Partials       80       80              
Flag Coverage Δ
python 81.65% <ø> (ø)
ruby-api 84.51% <ø> (-0.06%) ⬇️
ruby-backend 82.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Playwright

@sonarqubecloud
Copy link
Copy Markdown

@clayandgen
Copy link
Copy Markdown
Contributor Author

Fix Playwright

Resolved!

@mcosgriff
Copy link
Copy Markdown
Contributor

Should the dialog open when clicking on a different plugin?

@clayandgen clayandgen merged commit 8e67113 into main Oct 22, 2025
30 of 31 checks passed
@clayandgen clayandgen deleted the enhancement/sr-warning branch October 22, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SR warn when open or new with existing changes

4 participants