[Bug] Add overflow y scrolling on modified files list#2462
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2462 +/- ##
==========================================
+ Coverage 79.64% 79.66% +0.01%
==========================================
Files 658 658
Lines 50458 50458
Branches 741 741
==========================================
+ Hits 40189 40195 +6
+ Misses 10187 10181 -6
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openc3-cosmos-init/plugins/packages/openc3-vue-common/src/tools/admin/ModifiedPluginDialog.vue
Show resolved
Hide resolved
| :key="itemIndex" | ||
| >{{ file }}</v-list-item-subtitle | ||
| > | ||
| <div class="file-list-container"> |
There was a problem hiding this comment.
Since this is within a v-for already, if there are multiple entries in modifiedTargets, this will exist for each. Even just 2 modified targets will result in a dialog that is more than 100vh, due to the style for this class. Is this desired, or should there be a max-height set on the dialog?
There was a problem hiding this comment.
2 targets modified with a long list of files each. Each is scrollable with a max-height of 50vh, but the whole dialog flows off the screen and is not scrollable
There was a problem hiding this comment.
Outer dialog needs to be scrollable as well, and have a max height.
|
@EmilyRagan great catch! Here's the update, with the outside area scrollable as well: |
|
3 participants
Made the list of modified items scrollable with an increased max-height to limit opportunities where scroll is necessary.
closes #2397