Fix ScriptRunner stuck in readonly with only custom roles#2458
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2458 +/- ##
==========================================
- Coverage 79.56% 79.55% -0.01%
==========================================
Files 658 658
Lines 50360 50405 +45
Branches 736 736
==========================================
+ Hits 40067 40100 +33
- Misses 10213 10225 +12
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
This was a timing issue where mounted was finishing before created when waiting on role API calls. |
| this.editor.setReadOnly(true) | ||
| this.editor.renderer.$cursorLayer.element.style.display = 'none' |
There was a problem hiding this comment.
Could you remove all the other places where this is set based on readOnlyUser (e.g. lines 1242-1245)? I'm not worried about thrashing, more just code maintainability
There was a problem hiding this comment.
It needs both. The watcher is a noop if the editor doesn't exist yet, and in that case you still need the later lines.
2 participants
closes #2455