Skip to content

fix openc3_set_versions script#2449

Merged
ryan-pratt merged 1 commit intomainfrom
bug/tool-generator
Oct 16, 2025
Merged

fix openc3_set_versions script#2449
ryan-pratt merged 1 commit intomainfrom
bug/tool-generator

Conversation

@ryan-pratt
Copy link
Copy Markdown
Contributor

@ryan-pratt ryan-pratt commented Oct 16, 2025

closes #2445

  • fix bug in script
  • reset broken package.json files to d11ad51
  • run script to update them to 6.9.1 (this sets "version" and common package dependency versions)
  • run script again to update to 6.9.2-beta0 (this sets "version" and DOESN'T set common package dependency versions since dependencies should stay at released versions per previous discussions)

- fix bug in script
- reset broken package.json files to
d11ad51
- run script to update them to 6.9.1
- run script again to update to 6.9.2-beta0
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.55%. Comparing base (5a581cd) to head (8525a48).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2449   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files         658      658           
  Lines       50377    50377           
  Branches      736      736           
=======================================
+ Hits        40075    40076    +1     
+ Misses      10222    10221    -1     
  Partials       80       80           
Flag Coverage Δ
python 81.68% <ø> (-0.01%) ⬇️
ruby-api 84.62% <ø> (+0.05%) ⬆️
ruby-backend 82.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
@openc3/[email protected] has Obfuscated code.

Confidence: 0.94

Location: Package overview

From: openc3/templates/widget/package.jsonnpm/@openc3/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@openc3/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
[email protected] has Obfuscated code.

Confidence: 0.95

Location: Package overview

From: ?npm/@openc3/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
[email protected] has Obfuscated code.

Confidence: 0.91

Location: Package overview

From: ?npm/@smui/[email protected]npm/@smui/[email protected]npm/@smui/[email protected]npm/@smui/[email protected]npm/@smui/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@ryan-pratt
Copy link
Copy Markdown
Contributor Author

For further confirmation...

> OPENC3_RELEASE_VERSION=6.9.3 ruby openc3_set_versions.rb
> git diff **/package.json > diff-6.9.3.txt
> git add -A && git commit -m "delete me"
> OPENC3_RELEASE_VERSION=6.9.4-beta0 ruby openc3_set_versions.rb
> git diff **/package.json > diff-6.9.4-beta0.txt

diff-6.9.3.txt
diff-6.9.4-beta0.txt

@@ -1,2 +1,48 @@
{
"name": "<%= tool_name %>",
"version": "6.9.2-beta0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking it should be beta0?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the tool version should match the COSMOS version. It's just dependencies of generated tools that get a released version (6.9.1 in this case)

@ryan-pratt ryan-pratt merged commit 281cf55 into main Oct 16, 2025
30 of 31 checks passed
@ryan-pratt ryan-pratt deleted the bug/tool-generator branch October 16, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool/Widget generator create corrupt package.json file

3 participants