Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2426 +/- ##
==========================================
- Coverage 79.58% 79.53% -0.05%
==========================================
Files 658 658
Lines 50287 50378 +91
Branches 736 736
==========================================
+ Hits 40020 40070 +50
- Misses 10187 10228 +41
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmilyRagan
force-pushed
the
script-runner-messages-scroll
branch
from
67fe224 to
ad7a2fa
Compare
EmilyRagan
requested review from
clayandgen,
jmthomas,
mcosgriff and
ryanmelt
jmthomas
approved these changes
Oct 11, 2025
Member
jmthomas
left a comment
jmthomas
left a comment
There was a problem hiding this comment.
Removing the calcHeight and going to a css solution is awesome. Works great!
clayandgen
reviewed
Oct 11, 2025
EmilyRagan
force-pushed
the
script-runner-messages-scroll
branch
from
0a05330 to
d75dff1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1852
closes OpenC3/cosmos-enterprise#233
I tested this with the
inlineprop set to true as well, even though I'm not sure if that is used anywhere yet.