Skip to content

Fix connecting to running suite#2409

Merged
jmthomas merged 3 commits intomainfrom
sr_suites
Oct 4, 2025
Merged

Fix connecting to running suite#2409
jmthomas merged 3 commits intomainfrom
sr_suites

Conversation

@jmthomas
Copy link
Copy Markdown
Member

@jmthomas jmthomas commented Oct 3, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.55%. Comparing base (b0eddcd) to head (47c64ec).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...r-api/app/controllers/running_script_controller.rb 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2409      +/-   ##
==========================================
+ Coverage   79.53%   79.55%   +0.01%     
==========================================
  Files         657      657              
  Lines       50230    50235       +5     
  Branches      736      736              
==========================================
+ Hits        39952    39965      +13     
+ Misses      10198    10190       -8     
  Partials       80       80              
Flag Coverage Δ
python 81.78% <ø> (+0.06%) ⬆️
ruby-api 84.59% <20.00%> (-0.09%) ⬇️
ruby-backend 82.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthomas jmthomas marked this pull request as ready for review October 4, 2025 19:31
@jmthomas jmthomas requested a review from clayandgen October 4, 2025 19:31
name = running_script['filename']
file = Script.body(params[:scope], name)
# Since this is a running script the suite should process sucessfully
results_suites, _results_error, _success = Script.process_suite(name, file, username: username(), scope: params[:scope])

Check warning

Code scanning / CodeQL

Sensitive data read from GET request Medium

Route handler
for GET requests uses query parameter as sensitive data.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 4, 2025

@jmthomas jmthomas merged commit e31f82f into main Oct 4, 2025
30 checks passed
@jmthomas jmthomas deleted the sr_suites branch October 4, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants