Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
- Coverage 79.84% 79.53% -0.32%
==========================================
Files 654 657 +3
Lines 48770 50229 +1459
Branches 741 736 -5
==========================================
+ Hits 38941 39948 +1007
- Misses 9747 10201 +454
+ Partials 82 80 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ) | ||
| self.logger.error(f"Called with old_state = {old_limits_state}, new_state = {item.limits.state}") | ||
| self.logger.error(repr(error)) | ||
| self.logger.error(f"Limits Response error:\n{traceback.format_exc()}") |
There was a problem hiding this comment.
Is this the correct way to format an exception? Because we have repr(error) in 64 other places
There was a problem hiding this comment.
Created ticket to update everywhere.
| </Tabs> | ||
|
|
||
| ### unmap_target_from_interface | ||
|
|
There was a problem hiding this comment.
add > Since 6.9.0 ... throughout
| <TabItem value="ruby" label="Ruby Example"> | ||
|
|
||
| ```ruby | ||
| unmap_target_from_interface("INST", "INST_INT") |
There was a problem hiding this comment.
Add a line showing the keyword argument:
unmap_target_from_interface("INST2", "INST2_INT", cmd_only: true)
... throughout
| <TabItem value="python" label="Python Example"> | ||
|
|
||
| ```python | ||
| unmap_target_from_interface("INST", "INST_INT") |
There was a problem hiding this comment.
Add a line showing the keyword argument:
unmap_target_from_interface("INST2", "INST2_INT", cmd_only=True)
... throughout
|
2 participants
No description provided.