Disable std::filesystem for APPLE platforms to keep supporting MacOS deployment target with non-apple Clang#340
Conversation
|
Sorry, I was too focused on getting it to build, so I probably made the patch too harsh by using just Does this new patch look good? After it is solved here, I will submit the same patch to Nix. |
|
Wait a sec, it is not the proper check. it still includes std::filesystem for some reason :/ |
|
To be honest it doesn't matter that much, the day we decide to drop older Mac OS X support, we can fully move to native C++17 and delete all this stuff (but there is no good enough reason to right now). In the meantime, even if somebody chooses to manually set a higher deployment target, it shouldn't be a problem if |
k3a
force-pushed
the
apple_detect
branch
2 times, most recently
from
e2f26b9 to
87938a1
Compare
|
OK, the current commit is probably the cleanest. It includes the old comments and logic, has a new block for Apple and uses tabs for indentation. Please review. After this is merged, I will finish the Nix package update. Thanks! |
2 participants
This pull request replaces #339 and fixes Nix builds on macOS for 9.95.2 version.
With that, I am also updating the Nix-specific update script so that it will look into GitHub's Releases to ensure it won't update the package to a release marked as a pre-release.
So the next Nix version will be 9.95.2 🎉