Support running publish workflow on aarch64 runners #227

Activity

1. Cadair

   added

   enhancementNew feature or requestNew feature or request

   on Sep 15, 2024
2. Cadair commented on Sep 16, 2024

   

   Cadair

   on Sep 16, 2024

   MemberAuthor

   More actions

   @ConorMacBride I don't suppose you have any quick input on this before I start fumbling around in the dark?
3. ConorMacBride commented on Sep 16, 2024

   

   ConorMacBride

   on Sep 16, 2024

   Member

   More actions

   We could support something like this to modify the default image? Should just be a matter of updating get_matrix_item to extract the options depending on whether it receives a string or a dict.

   jobs:
     publish:
       uses: OpenAstronomy/github-actions-workflows/.github/workflows/publish.yml@v1
       with:
         test_extras: test
         test_command: pytest --pyargs test_package
         targets: |
           - linux
           - build: cp3?-manylinux_aarch64
             runs-on: ubuntu-latest-aarch64
           - cp3?-macosx_x86_64
       secrets:
         pypi_token: ${{ secrets.pypi_token }}

   github-actions-workflows/tools/load_build_targets.py

   Lines 68 to 75 in a0669d9

   	def get_matrix_item(target):
   	return {
   	"target": target,
   	"os": get_os(target),
   	"CIBW_BUILD": get_cibw_build(target),
   	"CIBW_ARCHS": get_cibw_archs(target),
   	"artifact-name": get_artifact_name(target),
   	}
4. pllim commented on Sep 17, 2024

   

   pllim

   on Sep 17, 2024

   Contributor

   More actions

   Astropy is very interested. Please keep us updated. Thanks!
5. Cadair commented on Nov 11, 2024

   

   Cadair

   on Nov 11, 2024

   MemberAuthor

   More actions

   @ConorMacBride What do you think the best solution for detecting when to use QEMU is?
   i.e. what should we change this to:
   

   github-actions-workflows/.github/workflows/publish.yml

   Line 148 in e3cc524

   if: ${{ matrix.CIBW_ARCHS == 'aarch64' }}

   Should we make it check to see if CIBW_ARCH is not equal to the native arch? I have no idea how we would do that.
6. ConorMacBride commented on Nov 12, 2024

   

   ConorMacBride

   on Nov 12, 2024

   Member

   More actions

   Cibuildwheel docs say that it supports QEMU on Linux. The cibuildwheel and QEMU docs suggests that the QEMU action is needed for aarch64 ppc64le s390x. As you say, I think it might be sufficient to just check we are on Linux (uname -s) and CIBW_ARCHS contains one of those three or all, excluding the native architecture. uname -m might be sufficient. I just tested it on a RPi4 and it outputs aarch64.
7. astrofrog

   closed this as completedin #247on Nov 26, 2024