Skip to content

Feature/platformio#37

Merged
ClutchplateDude merged 4 commits intoOpenAstroTech:developfrom
andre-stefanov:feature/platformio
Jun 15, 2020
Merged

Feature/platformio#37
ClutchplateDude merged 4 commits intoOpenAstroTech:developfrom
andre-stefanov:feature/platformio

Conversation

@andre-stefanov
Copy link
Member

@andre-stefanov andre-stefanov commented Jun 14, 2020 •
edited
Loading

This PR introduces usage of PlatformIO. Following changes were made:

  • most .ino files were renamed to .hpp (only OpenAstroTracker.ino kept its name to keep support for Arduino IDE)
  • OpenAstroTracker.ino includes previous .ino files in alphabetical order to mimic previos behavior of Arduino IDE
  • added #pragma once to former .ino files (now .hpp)
  • in c722_menuPOI.hpp the POI "M42 Orion Nbula" had to be commented out for now because it uses an invalid byte (unit8) value -5 and causes compile error. There is a fix by @ClutchplateDude on its way.
  • added UNO, MEGA2560 and ESP8266 as supported platforms
  • added void processSerialData(); declaration on top of f_seial.hpp because it was calling this function before it was defined
  • added #include "f_serial.hpp" to c_buttons.hpp because it depends on serial without including it. This dependency was somehow fixed by Arduino IDE before.
  • removed VMicro configurations because they would be broken due to the file renamings and it is easier to generate them anew instead of me touching them manually without a possibility to test them. Feel free to generate them and push to this PR.

@andre-stefanov andre-stefanov changed the base branch from master to develop June 14, 2020 00:44
ClutchplateDude
ClutchplateDude requested changes Jun 14, 2020
View reviewed changes
@jwellman80
Copy link
Collaborator

jwellman80 commented Jun 14, 2020

I have no issue with this PR. The VSMicro stuff can be easily regenerated. I need to play with PlatformIO portion a little more though.

@andre-stefanov
Copy link
Member Author

andre-stefanov commented Jun 15, 2020 •
edited
Loading

I have improved the configuration. Added Esp32 and fixed the definitions like ESP32 not being recognized properly. The only thing i am not completelly sure of was a required adaption to the TimerInterrupt.cpp, which was lacking a #if !defined(ESP32) and thus included the TimerInterrupt.h. I have extended the macro but since these files are actually a library, i dont know if we really should touch them.

@ClutchplateDude ClutchplateDude merged commit 828be1f into OpenAstroTech:develop Jun 15, 2020
@andre-stefanov andre-stefanov deleted the feature/platformio branch June 15, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ClutchplateDude ClutchplateDude Awaiting requested review from ClutchplateDude

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andre-stefanov @jwellman80 @ClutchplateDude