Skip to content

fix: run docker with the --user argument#659

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
DisruptiveLabs:docker-user
Sep 5, 2022
Merged

fix: run docker with the --user argument#659
wing328 merged 1 commit intoOpenAPITools:masterfrom
DisruptiveLabs:docker-user

Conversation

@kageurufu
Copy link
Copy Markdown
Contributor

This fixes generated clients being owned by root when using runDocker

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 2, 2022

have you reviewed this PR: #654 ?

looks like it's trying to fix the same problem.

can you please give it a try (test it locally) and if it works, we'll merge #654 instead ?

@kageurufu
Copy link
Copy Markdown
Contributor Author

I had seen #654, but I believe that approach is not usable cross-platform.

Copy link
Copy Markdown
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. looks like this approach is better

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 4, 2022

This branch is out-of-date with the base branch

can you please merge the latest master into your branch so that i can merge? thanks again for the PR.

This fixes generated clients being owned by root when using runDocker
@kageurufu
Copy link
Copy Markdown
Contributor Author

I rebased out of habit, but its pushed!

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 4, 2022

Thanks. I'll merge it on Monday.

@wing328 wing328 merged commit aa303d0 into OpenAPITools:master Sep 5, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 5, 2022

🎉 This PR is included in version 2.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants