Add extension to store oneOf/anyOf/allOf objects as full properties#9977
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Aug 22, 2021
Merged
Add extension to store oneOf/anyOf/allOf objects as full properties#9977wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
therve
approved these changes
Jul 19, 2021
Member
|
@zippolyte thanks for the enhancement. I'll review later this week and let you know if I've any questions. |
Contributor
Author
|
@wing328 I just merged master hoping it fixes the circle ci build 🙂 |
wing328
reviewed
Aug 22, 2021
Member
|
cc @OpenAPITools/generator-core-team as the change covers default codegen as well. |
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oneOf, anyOf and allOf in a composed schema only store the names of the different objects, so it's not possible to do complex things in the templates depending on things like type of object (things like
isArray,isEnum,isPrimitive, ...).This PR converts the objects to properties and stores them in the vendor extensions
x-(oneOf|anyOf|allOf)-as-propertiesto be used in templates.cc @wing328 @jimschubert, would appreciate some feedback on this, thanks 🙂
I plan on using them in custom templates for now, so I have no template change in this PR, but I feel this could be useful to have here.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.3.x,6.0.x