Skip to content

[dart] Fix tests failing in CI after automatic dependency update#9961

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
kuhnroyal:dart/fix-master
Jul 16, 2021
Merged

[dart] Fix tests failing in CI after automatic dependency update#9961
wing328 merged 1 commit intoOpenAPITools:masterfrom
kuhnroyal:dart/fix-master

Conversation

@kuhnroyal
Copy link
Copy Markdown
Contributor

@kuhnroyal kuhnroyal commented Jul 16, 2021

  • prevent future problems of this kind by adding the pubspec.lock file to VCS for all 3 test projects

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@kuhnroyal
[dart] Fix tests failing in CI after automatic dependency update
4a1d7ec 
* prevent future problems of this kind by adding the pubspec.lock file to VCS for all 3 test projects
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jul 16, 2021

prevent future problems of this kind by adding the pubspec.lock file to VCS for all 3 test projects

Thanks for the PR. That's one way to tackle the CI failure. To share a bit more, we do not commit the package lock files for some other client/server samples so that the CI can spot the issues when a newer dependency is installed. We may fix the issue by updating the templates/generators or committing the package lock file if no one can find the time to fix the issue in the near term.

@kuhnroyal
Copy link
Copy Markdown
Contributor Author

kuhnroyal commented Jul 16, 2021

prevent future problems of this kind by adding the pubspec.lock file to VCS for all 3 test projects

Thanks for the PR. That's one way to tackle the CI failure. To share a bit more, we do not commit the package lock files for some other client/server samples so that the CI can spot the issues when a newer dependency is installed. We may fix the issue by updating the templates/generators or committing the package lock file if no one can find the time to fix the issue in the near term.

These 3 lock files are only for projects with handwritten tests, not for any generated code. As you have said, for generated samples we want CI to fail and require a correct fix.

@wing328 wing328 added this to the 5.2.1 milestone Jul 16, 2021
@wing328 wing328 merged commit 5920bbd into OpenAPITools:master Jul 16, 2021
@kuhnroyal kuhnroyal deleted the dart/fix-master branch July 16, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: Dart Enhancement: CI/Test

Projects

None yet

Milestone

5.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@kuhnroyal @wing328