[dart-dio-next] only remove typed_data import if safe#9956
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jul 19, 2021
Merged
[dart-dio-next] only remove typed_data import if safe#9956wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
amondnet
approved these changes
Jul 16, 2021
agilob
reviewed
Jul 16, 2021
Contributor
|
Good catch, thanks for the PR! Would you mind moving the whole block directly beneath L:324 and adding a comment that this needs to be done due to the |
4eafc1d to
aa4bfea
Compare
Contributor
Author
Done. |
aa4bfea to
6cf91b1
Compare
kuhnroyal
approved these changes
Jul 19, 2021
Contributor
kuhnroyal
left a comment
There was a problem hiding this comment.
Thanks, I missed this on the original change!
Member
|
CircleCI failure not related to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #9955 by only removing the import for
dart:typed_dataif there are no parameters AND no responses of typeUInt8List.Previously only parameters were being checked, meaning invalid dart code would be generated if there was a
UInt8Listresponse, because the import would have been removed.Have tested against the example I provided in the bug report, as well as our own codebase where the error was first identified.
Have run
./bin/generate-samples.sh, but as the Petstore API does not have any file responses, there were no changes to the generated code.@swipesight @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob (2020/12)
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.3.x,6.0.x