Skip to content

[csharp] fix Optional param data type#9885

Merged
wing328 merged 8 commits intoOpenAPITools:masterfrom
devhl-labs:optional-param-dataType
Jul 13, 2021
Merged

[csharp] fix Optional param data type#9885
wing328 merged 8 commits intoOpenAPITools:masterfrom
devhl-labs:optional-param-dataType

Conversation

@devhl-labs
Copy link
Copy Markdown
Contributor

This will fix an issue where an operation's optional parameters are not marked as nullable when nullableReferenceTypes is enabled.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

@devhl-labs
Copy link
Copy Markdown
Contributor Author

circleci failed on checking go which is unreleated. AppVeyor has Org.OpenAPITools.Test.Api.PetApiTestsV2.DeletePetAsync_GivenNotExistentId_ThrowsApiException [FAIL] which is not related. The test seems flawed.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jul 13, 2021

LGTM

@wing328 wing328 merged commit 519ab92 into OpenAPITools:master Jul 13, 2021
@wing328 wing328 added this to the 5.2.1 milestone Jul 13, 2021
@wing328 wing328 changed the title [abstract csharp] Optional param data type [csharp] fix Optional param data type Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants