[Java][Spring] fix unhandledException not working in combination with…#9879
Conversation
|
failed circleci build shouldn't be related to the current changes |
322c2a4 to
a297e65
Compare
|
Can i do anything to help getting this PR merged? |
a297e65 to
0c3efaf
Compare
0c3efaf to
921fde1
Compare
|
Updated everything again, maybe someone can have a quick look at this small fix? @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) |
…ith skipDefaultInterface
eb7944e to
b743030
Compare
|
everything green again (cc @wing328) |
|
Hi @daberni |
|
Thanks for the hint @borsch. Did a rebase today and it looks like someone else already made this fix, and I didn't notice this during conflict resolution. Feel free to keep the sample for verification in the future, or decline if it isn't necessary. I guess maintainers could close the referenced issue then, but don't know when this was actually fixed. |
|
@daberni thanks for the PR. We'll include the sample in the Github workflow tests for the Spring generator. |
Fixes #4393 JavaSpring template by taking configuration options
skipDefaultInterfaceandunhandledExceptioninto account simultaneously properly.unhandledExceptionis no longer dependent onskipDefaultInterfaceas it is applicable to all java versions and implementations independent from abstract classes, interfaces or interfaces with default implementations.Added additional samples to verify this change and existing samples didn't get touched by it:
e.g.
becomes
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x