Skip to content

Define content type only if the body is not empty#9766

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
romanblack1:romanblack1-patch-1-1
Sep 25, 2021
Merged

Define content type only if the body is not empty#9766
wing328 merged 3 commits intoOpenAPITools:masterfrom
romanblack1:romanblack1-patch-1-1

Conversation

@romanblack1
Copy link
Copy Markdown
Contributor

Content type is now only defined if the body is not empty. It used to define empty bodies and the default "application/json." This satisfies the request #8116. This change aims to change the python client only.

I ran the desired commands on Git Bash without errors, but I am still new to this so I might have missed a step somewhere, let me know if there is anything I missed.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 15, 2021

Please update the samples via item3 in the PR checklist: https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md so that the CI can test the change.

@romanblack1
Copy link
Copy Markdown
Contributor Author

Please update the samples via item3 in the PR checklist: https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md so that the CI can test the change.

How do I make the results of the Git Bash visible to you? Are there files to change/commit to?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 20, 2021

Yes please commit the changes in the sample as well.

@romanblack1
Copy link
Copy Markdown
Contributor Author

I have updated the samples folder.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 24, 2021

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

@romanblack1 romanblack1 reopened this Jun 29, 2021
@romanblack1 romanblack1 reopened this Jun 30, 2021
@romanblack1 romanblack1 force-pushed the romanblack1-patch-1-1 branch from 8410564 to 5203b0e Compare July 6, 2021 22:32
@wing328 wing328 changed the title define content type iff the body is not empty Define content type only if the body is not empty Sep 25, 2021
@wing328 wing328 added this to the 5.3.0 milestone Sep 25, 2021
@wing328 wing328 merged commit 7384a1e into OpenAPITools:master Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants