Fix to allow tests to be generated under pythonSrcRoot (This change also adds AssertJ)#9674
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Oct 24, 2021
Merged
Conversation
spacether
reviewed
Jun 4, 2021
Contributor
Author
|
Hey @spacether @wing328 any thoughts on when this PR can move forward? |
5657734 to
21a8e18
Compare
spacether
reviewed
Oct 23, 2021
…enerated under the pythonSrcRoot directory if it's specified. This change also introduces AssertJ as a new dependency.
21a8e18 to
63b459d
Compare
Contributor
|
Thank you for the CLI option name tweak. Your PR looks good but I am seeing a test failure about a docs issue. |
Member
|
I'll update the doc after merging this PR into the master. Thanks again for the PR and sorry for the delay in reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(#9673) This change introduces a flag to have tests generated under the pythonSrcRoot directory if it's specified.
This change also introduces AssertJ as a new dependency. I've updated the tests in this PR to use AssertJ.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.xcc: @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether