Skip to content

Fix to allow tests to be generated under pythonSrcRoot (This change also adds AssertJ)#9674

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
tray2100:pythonSrcRootTestFix
Oct 24, 2021
Merged

Fix to allow tests to be generated under pythonSrcRoot (This change also adds AssertJ)#9674
wing328 merged 1 commit intoOpenAPITools:masterfrom
tray2100:pythonSrcRootTestFix

Conversation

@tray2100
Copy link
Copy Markdown
Contributor

@tray2100 tray2100 commented Jun 4, 2021

(#9673) This change introduces a flag to have tests generated under the pythonSrcRoot directory if it's specified.

This change also introduces AssertJ as a new dependency. I've updated the tests in this PR to use AssertJ.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether

Comment thread docs/generators/python-aiohttp.md Outdated
@wing328 wing328 added this to the 5.2.0 milestone Jun 9, 2021
@wing328 wing328 modified the milestones: 5.2.0, 5.2.1 Jul 13, 2021
@wing328 wing328 modified the milestones: 5.2.1, 5.3.0 Aug 17, 2021
@tray2100
Copy link
Copy Markdown
Contributor Author

Hey @spacether @wing328 any thoughts on when this PR can move forward?

@tray2100 tray2100 force-pushed the pythonSrcRootTestFix branch from 5657734 to 21a8e18 Compare October 21, 2021 23:03
…enerated under the pythonSrcRoot directory if it's specified.

This change also introduces AssertJ as a new dependency.
@tray2100 tray2100 force-pushed the pythonSrcRootTestFix branch from 21a8e18 to 63b459d Compare October 23, 2021 06:14
@spacether
Copy link
Copy Markdown
Contributor

spacether commented Oct 23, 2021

Thank you for the CLI option name tweak. Your PR looks good but I am seeing a test failure about a docs issue.
Can you rebase and run:
bin/utils/ensure-up-to-date?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 24, 2021

I'll update the doc after merging this PR into the master.

Thanks again for the PR and sorry for the delay in reviewing.

@wing328 wing328 merged commit 91d0e2d into OpenAPITools:master Oct 24, 2021
@wing328 wing328 changed the title (#9673) Fix to allow tests to be generated under pythonSrcRoot. This change also adds AssertJ. Fix to allow tests to be generated under pythonSrcRoot (This change also adds AssertJ) Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants