[dart][dart-dio] Update docs for dart-dio-next#9584
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom May 27, 2021
Merged
[dart][dart-dio] Update docs for dart-dio-next#9584wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
* remove deprecated author field from all pubspec templates * improve dart-dio-next readme/markdown documentation * add a lot of dart-doc to model and API classes
agilob
reviewed
May 26, 2021
| description: {{pubDescription}} | ||
| homepage: {{pubHomepage}} | ||
| authors: | ||
| - '{{{pubAuthor}}} <{{{pubAuthorEmail}}}>' |
Contributor
There was a problem hiding this comment.
someone recently added this. why removing it?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I can leave it for the old generators but definitely removing it for dart-dio-next.
Contributor
There was a problem hiding this comment.
oh didnt know that, funny someone added this in the last month or two
agilob
reviewed
May 26, 2021
| ```dart | ||
| import 'package:openapi/api.dart'; | ||
|
|
||
| var api_instance = new StoreApi(); |
Contributor
There was a problem hiding this comment.
I feel a bit cheated with name of this PR. these changed dont belong here imo.
Contributor
Author
There was a problem hiding this comment.
Can you elaborate? The existing samples have been wrong from the first day.
Contributor
Author
There was a problem hiding this comment.
These are sample code snippets in markdown files in case you missed that :o
agilob
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.xCC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)