Skip to content

[cpp-restsdk] Update json double/float parse.#9577

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
adameste:cpp-decimal-point-parse
May 28, 2021
Merged

[cpp-restsdk] Update json double/float parse.#9577
wing328 merged 2 commits intoOpenAPITools:masterfrom
adameste:cpp-decimal-point-parse

Conversation

@adameste
Copy link
Copy Markdown
Contributor

@adameste adameste commented May 25, 2021

Fix cpp-restsdk double and float parse.

double.NaN was parsed when server doesn't ensure the floating point value has decimal point in in.

Fixed incorrect server response json parsing. For example the following json:

{
    "double_value": 42
}

As of now, the value 42 is parsed as NaN, because json library returns false on is_double().
Additional condition ensures NaN is not returned when not needed.
Implemented for both float & double data types.

@adameste
[cpp-restsdk] Update json double/float parse.
7934bc8 
Fix cpp-restsdk double and float parse.

double.NaN was parsed when server doesn't ensure the floating point value has decimal point in in.
@wing328
Copy link
Copy Markdown
Member

wing328 commented May 27, 2021

Thanks for the PR. Please follow the instruction in the PR template below to update the samples so that CI can test the change:

  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.

cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

@adameste
Copy link
Copy Markdown
Contributor Author

adameste commented May 27, 2021

Ran all three above mentioned commands & commited changes.

@wing328 wing328 added this to the 5.2.0 milestone May 28, 2021
@wing328 wing328 merged commit 73b34ad into OpenAPITools:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@muttleyxd muttleyxd muttleyxd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Client: C++ Issue: Bug

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@adameste @wing328 @muttleyxd