[dart2] mustache templates minor improvements#9539
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom May 24, 2021
Merged
[dart2] mustache templates minor improvements#9539wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
Contributor
|
CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @wing328 Can you approve the workflow please. |
kuhnroyal
approved these changes
May 21, 2021
Contributor
kuhnroyal
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution!
agilob
approved these changes
May 21, 2021
josh-burton
approved these changes
May 21, 2021
Member
|
TravisCI and CircleCI failures not related to this change. |
premiumitsolution
pushed a commit
to premiumitsolution/openapi-generator
that referenced
this pull request
May 26, 2021
* fix: prefer_is_not_empty linter suggestion * fix: annotate_overrides linter suggestion * chore: update samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two nits in
dart2mustache templates that should satisfy linter:@overridetoString (ruleannotate_overrides)isNotEmptyinstead of!isEmpty(ruleprefer_is_not_emty)@kuhnroyal
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x