Skip to content

[dart2] mustache templates minor improvements#9539

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
bonitoo-io:fix/dart2-mustache-nits
May 24, 2021
Merged

[dart2] mustache templates minor improvements#9539
wing328 merged 3 commits intoOpenAPITools:masterfrom
bonitoo-io:fix/dart2-mustache-nits

Conversation

@alespour
Copy link
Copy Markdown
Contributor

Fixes two nits in dart2 mustache templates that should satisfy linter:

  • add @override toString (rule annotate_overrides)
  • use String's isNotEmpty instead of !isEmpty (rule prefer_is_not_emty)

@kuhnroyal

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@kuhnroyal
Copy link
Copy Markdown
Contributor

CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

@wing328 Can you approve the workflow please.

Copy link
Copy Markdown
Contributor

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@alespour alespour marked this pull request as ready for review May 21, 2021 14:14
@wing328
Copy link
Copy Markdown
Member

wing328 commented May 24, 2021

TravisCI and CircleCI failures not related to this change.

@wing328 wing328 merged commit e360228 into OpenAPITools:master May 24, 2021
@wing328 wing328 added this to the 5.2.0 milestone May 24, 2021
@wing328 wing328 changed the title fix: dart2 mustache templates minor improvements [dart2] mustache templates minor improvements May 24, 2021
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
* fix: prefer_is_not_empty linter suggestion

* fix: annotate_overrides linter suggestion

* chore: update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants