Skip to content

update samples#9288

Merged
macjohnny merged 1 commit intomasterfrom
update-samples
Apr 19, 2021
Merged

update samples#9288
macjohnny merged 1 commit intomasterfrom
update-samples

Conversation

@macjohnny
Copy link
Copy Markdown
Member

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@macjohnny macjohnny merged commit aa5adbf into master Apr 19, 2021
@wing328 wing328 deleted the update-samples branch April 20, 2021 07:05
@wing328 wing328 added this to the 5.1.1 milestone Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants